[PATCH] fdo#42781 WaE: unreachable code

Petr Kraus (via Code Review) gerrit at gerrit.libreoffice.org
Tue Mar 26 13:01:00 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3066

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/3066/1

fdo#42781 WaE: unreachable code

Encapsulate whole switch case code by #if
so it does not produce unreachable code when TRUE
Also found second occurence in function overload.

Change-Id: I2f726b4e9cad56850ce360e48f96f45137befe96
---
M sc/source/core/tool/interpr4.cxx
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index bfd9494..a3d77ff 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -543,10 +543,10 @@
         break;
 #if OSL_DEBUG_LEVEL > 0
         case CELLTYPE_DESTROYED:
-#endif
             SetError(errCellNoValue);
             fValue = 0.0;
         break;
+#endif
     }
 
     return fValue;
@@ -610,10 +610,10 @@
         break;
 #if OSL_DEBUG_LEVEL > 0
         case CELLTYPE_DESTROYED:
-#endif
             SetError(errCellNoValue);
             fValue = 0.0;
         break;
+#endif
     }
 
     return fValue;

-- 
To view, visit https://gerrit.libreoffice.org/3066
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f726b4e9cad56850ce360e48f96f45137befe96
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Petr Kraus <petr_kraus at email.cz>



More information about the LibreOffice mailing list