[PATCH] coverity#982290 Logically dead code

Julien Nabet (via Code Review) gerrit at gerrit.libreoffice.org
Tue Mar 26 13:05:54 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3067

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/3067/1

coverity#982290 Logically dead code

Change-Id: Ia684369faa5fd0eb854d204ac7e8dbf74f032606
---
M connectivity/source/drivers/postgresql/pq_updateableresultset.cxx
1 file changed, 1 insertion(+), 2 deletions(-)



diff --git a/connectivity/source/drivers/postgresql/pq_updateableresultset.cxx b/connectivity/source/drivers/postgresql/pq_updateableresultset.cxx
index ac8b50db..dbbec1e 100644
--- a/connectivity/source/drivers/postgresql/pq_updateableresultset.cxx
+++ b/connectivity/source/drivers/postgresql/pq_updateableresultset.cxx
@@ -448,8 +448,7 @@
     checkUpdate( columnIndex );
 
     Statics &st = getStatics();
-    if( x )
-        m_updateableField[columnIndex-1].value <<=  ( x ? st.TRUE : st.FALSE );
+    m_updateableField[columnIndex-1].value <<=  ( x ? st.TRUE : st.FALSE );
 
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/3067
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia684369faa5fd0eb854d204ac7e8dbf74f032606
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412 at yahoo.fr>



More information about the LibreOffice mailing list