About coverity 441020 (templdlg.cxx in sfx2)

[julien2412]

Hello,

coverity scan reported this:
CID 441020 (#1 of 1): Dereference after null check (FORWARD_NULL)6.
var_deref_model: Passing null pointer "pOldStyleSheetPool" to function
"SfxListener::StartListening(SfxBroadcaster &, sal_Bool)", which
dereferences it. 

Indeed:

2650        if ( pOldStyleSheetPool )
2651            EndListening(*pOldStyleSheetPool);
    
2652        if ( pStyleSheetPool )
2653            StartListening(*pOldStyleSheetPool);

So I pushed a patch here:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=cab7f6476f7d0f17bf2f1400bf93fb1b7fbd1625
- StartListening(*pOldStyleSheetPool);
+ StartListening(*pStyleSheetPool);

If it's ok, could it be interesting to cherry-pick it into 4.0 branch? (I
don't have 4.0 sources, only master)

Julien



--
View this message in context: http://nabble.documentfoundation.org/About-coverity-441020-templdlg-cxx-in-sfx2-tp4047124.html
Sent from the Dev mailing list archive at Nabble.com.