[PATCH] coverity#983561: Arguments in wrong order

Regina Henschel rb.henschel at t-online.de
Sun Mar 31 06:49:09 PDT 2013


Hi Arnold,

Thomas Arnhold schrieb:
> Hi Regina,
>
> you're right, the other methods are using the order (fVer, fHor), like
> createUnitSpherePolyPolygon() does. So the definition is correct:
>
> inline B3DPoint getPointFromCartesian(double fVer, double fHor)
>
> But on the call side it's used like:
>
> aNew.append(getPointFromCartesian(fHor, fVer));
>
> So here got something mixed up.

Draw a sphere from the set of predefined 3D-objects and set the line 
style to continues to see the segments. Set "Segments Vertical" to 8 to 
see, which part of the drawing is affected by "Vertical".

In Version 4.0.1.2 (Build ID: 84102822e3d61eb989ddd325abf1ac077904985) 
the poles are top and bottom, which is correct.

In Version 4.1.0.0.alpha0+ (Build ID: 
2c9d3817429b1537ea31521cb263a52ce9c7968) the poles are left and right, 
which is wrong.

The identifiers in the original implementation are odd, but the 
calculation itself is correct.

Kind regards
Regina


More information about the LibreOffice mailing list