[PATCH] fdo#62096 Replace O(U)String compareTo with ==

Efe Gürkan Yalaman (via_Code_Review) gerrit at gerrit.libreoffice.org
Sun Mar 31 07:35:52 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3136

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/3136/1

fdo#62096 Replace O(U)String compareTo with ==

Change-Id: Id89b7eeb09b5cd7cee449cd1a20fb13b630f29c4
---
M framework/source/fwe/xml/toolboxdocumenthandler.cxx
1 file changed, 6 insertions(+), 6 deletions(-)



diff --git a/framework/source/fwe/xml/toolboxdocumenthandler.cxx b/framework/source/fwe/xml/toolboxdocumenthandler.cxx
index 21a13e2..97ec8ce 100644
--- a/framework/source/fwe/xml/toolboxdocumenthandler.cxx
+++ b/framework/source/fwe/xml/toolboxdocumenthandler.cxx
@@ -426,17 +426,17 @@
                     //fix for fdo#39370
                     /// check whether RTL interface or not
                     if(Application::GetSettings().GetLayoutRTL()){
-                        if (aCommandURL.compareTo(".uno:ParaLeftToRight") == 0)
+                        if (aCommandURL == ".uno:ParaLeftToRight")
                             aCommandURL = ".uno:ParaRightToLeft";
-                        else if (aCommandURL.compareTo(".uno:ParaRightToLeft") == 0)
+                        else if (aCommandURL == ".uno:ParaRightToLeft")
                             aCommandURL = ".uno:ParaLeftToRight";
-                        else if (aCommandURL.compareTo(".uno:LeftPara") == 0)
+                        else if (aCommandURL == ".uno:LeftPara")
                             aCommandURL = ".uno:RightPara";
-                        else if (aCommandURL.compareTo(".uno:RightPara") == 0)
+                        else if (aCommandURL == ".uno:RightPara")
                             aCommandURL = ".uno:LeftPara";
-                        else if (aCommandURL.compareTo(".uno:AlignLeft") == 0)
+                        else if (aCommandURL == ".uno:AlignLeft")
                             aCommandURL = ".uno:AlignRight";
-                        else if (aCommandURL.compareTo(".uno:AlignRight") == 0)
+                        else if (aCommandURL == ".uno:AlignRight")
                             aCommandURL = ".uno:AlignLeft";
                     }
 

-- 
To view, visit https://gerrit.libreoffice.org/3136
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id89b7eeb09b5cd7cee449cd1a20fb13b630f29c4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Efe Gürkan Yalaman <efeyalaman at gmail.com>



More information about the LibreOffice mailing list