[PATCH] $(WORKDIR)/CustomTarget/odk/odkcommon is no more

David Tardon (via Code Review) gerrit at gerrit.libreoffice.org
Sat May 4 06:25:20 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3777

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/3777/1

$(WORKDIR)/CustomTarget/odk/odkcommon is no more

Change-Id: I49204b3518c47614e591de47a916901861331673
---
M odk/CustomTarget_check.mk
M odk/util/check.pl
2 files changed, 6 insertions(+), 8 deletions(-)



diff --git a/odk/CustomTarget_check.mk b/odk/CustomTarget_check.mk
index 74415a2..fb5b2d5 100644
--- a/odk/CustomTarget_check.mk
+++ b/odk/CustomTarget_check.mk
@@ -50,7 +50,6 @@
 	$(call gb_Helper_print_on_error,\
 		$(PERL) $< \
 			$(INSTDIR)/$(gb_Package_SDKDIRNAME) \
-			$(call gb_CustomTarget_get_workdir,odk/odkcommon) \
 			$(odk_PLATFORM) "$(gb_Executable_EXT)" \
 		,$@.log \
 	)
diff --git a/odk/util/check.pl b/odk/util/check.pl
index 542361e..5a2df16 100644
--- a/odk/util/check.pl
+++ b/odk/util/check.pl
@@ -23,26 +23,25 @@
 
 $return = 0;
 
-$PrimaryDir = "$ARGV[0]";
-$SecondaryDir = "$ARGV[1]";
-$OperatingSystem = "$ARGV[2]";
-$ExePrefix = "$ARGV[3]";
+$SdkDir = "$ARGV[0]";
+$OperatingSystem = "$ARGV[1]";
+$ExePrefix = "$ARGV[2]";
 
 sub check_file
 {
     my ($file) = @_;
-    return -e "$PrimaryDir/$file" || -e "$SecondaryDir/$file";
+    return -e "$SdkDir/$file";
 }
 
 sub check_dir
 {
     my ($dir) = @_;
-    return -d "$PrimaryDir/$dir" || -d "$SecondaryDir/$dir";
+    return -d "$SdkDir/$dir";
 }
 
 print "Check for $OperatingSystem\n";
 
-if (-d "$PrimaryDir" || -d "$SecondaryDir") {
+if (-d "$SdkDir") {
     # check binaries
     print "check binaries: ";
     if (check_dir("bin")) {

-- 
To view, visit https://gerrit.libreoffice.org/3777
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49204b3518c47614e591de47a916901861331673
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Tardon <dtardon at redhat.com>



More information about the LibreOffice mailing list