should we drop DEFAULT_TO_ENGLISH_FOR_PACKING?

[David Tardon]

Hi all,

the installer uses a special variable DEFAULT_TO_ENGLISH_FOR_PACKING to
substitute en-US files if there are no files for "native" language (this
is used for the stuff from extras and help). The reasoning why it is
needed is in https://issues.apache.org/ooo/show_bug.cgi?id=45118 (Rene
had strong objections to it at the time). There are two problems with
it:

1. It does not work with FILELIST install. method (in fact, it breaks
   Windows build, because there are multiple references of the same file).
   The ARCHIVE method hacked this around by unpacking into lang-specific
   dirs.

2. It is effectively disabled anyway since commit
   165387b4e714d87ee080add6e45bc47fcde8e556 "WITH_LANG: add en-US if it is
   missing".

The question is: Do we see any reason to create install. sets that do
not contain en-US, as explained in i#45118 (in that case there are
several things that need to be fixed)? If not, we can just drop
DEFAULT_TO_ENGLISH_FOR_PACKING and the related code.

D.