[PATCH libreoffice-4-0] fdo#64211 replace "%2F" to "/" in online (wiki) help URLs

Andras Timar (via Code Review) gerrit at gerrit.libreoffice.org
Tue May 7 13:26:23 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3817

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/3817/1

fdo#64211 replace "%2F" to "/" in online (wiki) help URLs

It is not possible to create wiki pages with URLs that have %2F in
them. Help URLs contain %2F, when invoked from dialogs that are
based on .ui files, it seems this is the new HID syntax.

For example for Zoom dialog LibreOffice used to call
http://help.libreoffice.org/simpress/cui%2Fui%2Fzoomdialog%2Fzoomsb
and it did not work. Now it calls
http://help.libreoffice.org/simpress/cui/ui/zoomdialog/zoomsb
and it works.

Conflicts:

	sfx2/source/appl/sfxhelp.cxx

Change-Id: I163cf8ec3b69f31eadbbd9085d2180839fe91e07
---
M sfx2/source/appl/sfxhelp.cxx
1 file changed, 1 insertion(+), 0 deletions(-)



diff --git a/sfx2/source/appl/sfxhelp.cxx b/sfx2/source/appl/sfxhelp.cxx
index b2be3e3..7ed8bdd 100644
--- a/sfx2/source/appl/sfxhelp.cxx
+++ b/sfx2/source/appl/sfxhelp.cxx
@@ -660,6 +660,7 @@
 
     OUString aHelpLink( "http://help.libreoffice.org/"  );
     aHelpLink += rURL.Copy( aInternal.Len() );
+    aHelpLink = aHelpLink.replaceAlL("%2F","/");
     try
     {
         Reference< XSystemShellExecute > xSystemShell(

-- 
To view, visit https://gerrit.libreoffice.org/3817
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I163cf8ec3b69f31eadbbd9085d2180839fe91e07
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Andras Timar <atimar at suse.com>



More information about the LibreOffice mailing list