[PATCH] fdo#56995 Created global option to disable presenter console...

Norbert Thiebaud (via Code Review) gerrit at gerrit.libreoffice.org
Thu May 9 06:18:52 PDT 2013


Hello LibreOffice gerrit bot,

I'd like you to reexamine a rebased change.  Please visit

    https://gerrit.libreoffice.org/3762

to look at the new rebased patch set (#3).

Change subject: fdo#56995 Created global option to disable presenter console in Impress
......................................................................

fdo#56995 Created global option to disable presenter console in Impress

Changes made are as Follows
/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
	To add the new global checkbox to Libreoffice Impress>General>Start
	A new xml block for EnablePresenterScreen was added
		<prop oor:name="EnablePresenterScreen" oor:type="xs:boolean" >
		/sd/source/ui/app/optsitem.cxx
		To add the setter/getter for the new checkbox button, namely:
			SetEnablePresenterScreen
			IsEnablePresenterScreen
		EnablePresenterScreen added to index number 26 of:
			GetPropNameArray()
/sd/source/ui/dlg/tpoption.cxx
	SdTpOptionsMisc() editted to attach EnablePresenterScreen to CBX_ENABLE_PRESENTER_SCREEN
		aCbxEnablePresenterScreen  ( this, SdResId( CBX_ENABLE_PRESENTER_SCREEN))
	Also Added to FillItemSet() and Reset() functions
/sd/source/ui/dlg/tpoption.src b/sd/source/ui/dlg/tpoption.src
	enableSdRemote size changed to
		Size = MAP_APPFONT ( 116 , 10 ) ;
		Pos = MAP_APPFONT ( 12 , 171  ) ;
		158 was correct but 171 was added on request
		To allow enableSdRemote(CBX_ENABLE_SDREMOTE) and enablePresenterScreen( CBX_ENABLE_PRESENTER_SCREEN) to be drawn adjacent.
		enablePresenterScreen checkbox CBX_ENABLE_PRESENTER_SCREEN added
/sd/source/ui/inc/optsitem.hxx
	Set default value for enablePresenterScreen as 1 or TRUE
		sal_Bool    bEnablePresenterScreen : 1;
	Added getter/setter named same as above for interface definition
sd/source/ui/inc/tpoption.hrc
	Defined CBX_ENABLE_PRESENTER_SCREEN as 42nd checkbox
		#define CBX_ENABLE_PRESENTER_SCREEN 42
/sd/source/ui/inc/tpoption.hxx
	 Added interface declaration of aCbxEnablePresenterScreen which was attached to  CBX_ENABLE_PRESENTER_SCREEN
/sdext/source/presenter/PresenterScreen.hxx
	 Added interface declaration of
		bool isPresenterScreenEnabled()
		 to PresenterScreen class to allow presenterscreen to get if the option is checked
/sdext/source/presenter/PresenterScreen.cxx
	 Added definition of
		 isPresenterScreenEnabled(const css::uno::Reference<css::uno::XComponentContext>& rxContext)
			Input : Current Process Context
			Output : The 0/1 value of EnablePresenterScreen from presenterconfig
	In PresenterScreenListener::notifyEvent( )
		Added
			 if(mpPresenterScreen->isPresenterScreenEnabled(mxComponentContext)
				mpPresenterScreen->InitializePresenterScreen()
 		To initialize PresenterScreen only when enabled

Change-Id: If8242e607323df57d8e78d08cf2129d03c0c9e4f
---
M officecfg/registry/schema/org/openoffice/Office/Impress.xcs
M sd/source/ui/app/optsitem.cxx
M sd/source/ui/dlg/tpoption.cxx
M sd/source/ui/dlg/tpoption.src
M sd/source/ui/inc/optsitem.hxx
M sd/source/ui/inc/tpoption.hrc
M sd/source/ui/inc/tpoption.hxx
M sdext/source/presenter/PresenterScreen.cxx
M sdext/source/presenter/PresenterScreen.hxx
9 files changed, 56 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/3762/3
-- 
To view, visit https://gerrit.libreoffice.org/3762
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If8242e607323df57d8e78d08cf2129d03c0c9e4f
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Manik Malhotra <manik10044 at iiitd.ac.in>
Gerrit-Reviewer: LibreOffice gerrit bot <gerrit at libreoffice.org>
Gerrit-Reviewer: Norbert Thiebaud <nthiebaud at gmail.com>



More information about the LibreOffice mailing list