[PATCH] cppcheck: fix arrayIndexThenCheck in vcl

[Julien Nabet (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3868

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/3868/1

cppcheck: fix arrayIndexThenCheck in vcl

Change-Id: Id7258dd35c131c2c8151bc5e0f97076241e6d10f
---
M vcl/source/control/field.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/vcl/source/control/field.cxx b/vcl/source/control/field.cxx
index c035678..87043dd 100644
--- a/vcl/source/control/field.cxx
+++ b/vcl/source/control/field.cxx
@@ -201,7 +201,7 @@
     {
         // check if string is equivalent to zero
         sal_Int16 nIndex = bNegative ? 1 : 0;
-        while( aStr[nIndex] == '0' && nIndex < aStr.getLength() )
+        while (nIndex < aStr.getLength() && aStr[nIndex] == '0')
             ++nIndex;
         if( nIndex < aStr.getLength() )
         {

-- 
To view, visit https://gerrit.libreoffice.org/3868
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7258dd35c131c2c8151bc5e0f97076241e6d10f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet <serval2412 at yahoo.fr>