Cppcheck: throwing exception in destructor in SyncDbusSessionHelper.cxx (shell module)

[julien2412]

Hello,

Cppcheck reported exception thrown in destructor in
shell/source/sessioninstall/SyncDbusSessionHelper.cxx, line 39
     28     class GErrorWrapper
     29     {
     30         GError* m_pError;
     31         public:
     32             GErrorWrapper(GError* pError) : m_pError(pError) {}
     33             ~GErrorWrapper()
     34             {
     35                 if(!m_pError)
     36                     return;
     37                 OUString sMsg =
OUString::createFromAscii(m_pError->message);
     38                 g_error_free(m_pError);
     39                 throw RuntimeException(sMsg, NULL);
     40             }
     41             GError** getRef() { return &m_pError; }
     42     };

Should it be changed? If yes, how? (I suppose we shouldn't just remove it)

Julien



--
View this message in context: http://nabble.documentfoundation.org/Cppcheck-throwing-exception-in-destructor-in-SyncDbusSessionHelper-cxx-shell-module-tp4055493.html
Sent from the Dev mailing list archive at Nabble.com.