[PATCH] datetime.cxx (ISO8601parseTime) ‘bFrac’ may be used uninitia...

[Mark Wielaard (via Code Review)]

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3885

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/3885/1

datetime.cxx (ISO8601parseTime) ‘bFrac’ may be used uninitialized.

gcc 4.4.7 warns about the above because getISO8601TimeToken calls
impl_getISO8601TimeToken, but if impl_getISO8601TimeToken fails, then
o_bFraction will never be set.

Change-Id: I3dd9460391c0dcdef37110110ad623c1016f0ddc
---
M unotools/source/misc/datetime.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/unotools/source/misc/datetime.cxx b/unotools/source/misc/datetime.cxx
index cbfb169..93f60a6 100644
--- a/unotools/source/misc/datetime.cxx
+++ b/unotools/source/misc/datetime.cxx
@@ -392,7 +392,7 @@
     sal_Int32 n = 0;
     OUString tokInt;
     OUString tokFrac;
-    bool bFrac;
+    bool bFrac = false;
     // hours
     if (bSuccess && (bSuccess = getISO8601TimeToken(aTimeStr, n, tokInt, bFrac, tokFrac)))
     {

-- 
To view, visit https://gerrit.libreoffice.org/3885
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3dd9460391c0dcdef37110110ad623c1016f0ddc
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Mark Wielaard <mark at klomp.org>