[PATCH] resolved fdo#35756 import more than 64k HTML table cells

Olivier Hallot olivier.hallot at documentfoundation.org
Mon May 13 15:45:44 PDT 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Em 10-05-2013 08:28, Eike Rathke (via Code Review) escreveu:
> Hi,
> 
> I have submitted a patch for review:
> 
>     https://gerrit.libreoffice.org/3838
> 
> To pull it, you can do:
> 
>     git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/3838/1
> 
> resolved fdo#35756 import more than 64k HTML table cells
> 
> Enhanced EditEngine to be able to hold more than 64k paragraphs. Used
> also in RTF import Calc and Writer, so that could benefit as well.
> 
> * changed all EditEngine,Outliner,... related paragraph index/count
>   variables from sal_uInt16 to sal_Int32
>   * sal_Int32 instead of sal_uInt32 to match accessibility API
>   * matched some Outliner methods' paragraph parameters from sal_uLong
>     to sal_Int32
>   * containers capable to hold size_t nevertheless are limited to a
>     maximum of sal_Int32
> * changed definition of EE_PARA_NOT_FOUND and EE_PARA_ALL to
>   SAL_MAX_INT32
> + added EE_PARA_MAX_COUNT and EE_TEXTPOS_MAX_COUNT to initialize
>   ESelection with what previously were hard coded 0xFFFF all over the
>   place
> + for similar reason added EE_TEXTPOS_ALL corresponding to EE_PARA_ALL
>   to initialize an ESelection spanning all available text like
>   aSel(0,0,EE_PARA_ALL,EE_TEXTPOS_ALL)
> 
> Change-Id: I62d1b9c399cd709a4f93dbac31b219a61c46ec00

Hi Eike

Is this patch able to fix this decade-long issue as indicated in

https://issues.apache.org/ooo/show_bug.cgi?id=17171
https://issues.apache.org/ooo/show_bug.cgi?id=83427 ?

Thank you

Kind regards
- -- 
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany
Fundação responsável civilmente, de acordo com o direito civil
Detalhes Legais: http://www.documentfoundation.org/imprint
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQEcBAEBAgAGBQJRkW0YAAoJEJp3R7nH3vLxylgH/3VwZz8VyphOYmIALq2qIfW2
ODBeLkOCVs7AWjiX3rMTX/6EB2xFrdazVGdEuXCKQpu3NXIBEFuMaySyyCU5shdX
F6pOnDNb4VrpzNYvytSC2v7oohwqHbcvcX0TI06johUSs6GJ5u2NGAc8CZj9BYuS
xya4JpTOkMxzpd/SCgyOLAApWDJaDC/SFsNxtOAcDmwVIBQZFhWFCswFtlklB3Bz
iDATr1sJ+rMmPoVKWecOn1YECPJOcA0zD8Dq2jE/dDTE9iwf+1XW0AgO1El8Safw
R3BgbEoFZpGLMQyQjkXqJY8IUPyCuuspyhHHuOYfQnxCqXFWSQP9FHflWgQLTWc=
=E0Dh
-----END PGP SIGNATURE-----


More information about the LibreOffice mailing list