[PATCH libreoffice-4-0] fdo#64577, CMIS: fixed crasher in libcmis

Bosdonnat Cedric (via Code Review) gerrit at gerrit.libreoffice.org
Thu May 16 06:41:02 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3921

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/3921/1

fdo#64577, CMIS: fixed crasher in libcmis

The crash is handled, but the huge files' size won't be properly handled
on 32bits builds: would require a libcmis API change.

Change-Id: I8ef1190a4d1de7d91a67ec20330db9e1747dfdc2
(cherry picked from commit 7a6f5186a8e4089181f57af44fa4654fe692856b)
---
M libcmis/libcmis-0.3.0.patch
1 file changed, 13 insertions(+), 0 deletions(-)



diff --git a/libcmis/libcmis-0.3.0.patch b/libcmis/libcmis-0.3.0.patch
index d9dc70f..37644c8 100644
--- a/libcmis/libcmis-0.3.0.patch
+++ b/libcmis/libcmis-0.3.0.patch
@@ -20,3 +20,16 @@
      xmlTextWriterEndElement( writer ); // End of Expires
      xmlTextWriterEndElement( writer ); // End of Timestamp
  
+diff --git src/libcmis/document.cxx src/libcmis/document.cxx
+index 7c2a8e6..e7014cb 100644
+--- src/libcmis/document.cxx
++++ src/libcmis/document.cxx
+@@ -78,7 +78,7 @@ namespace libcmis
+     {
+         long contentLength = 0;
+         map< string, libcmis::PropertyPtr >::const_iterator it = getProperties( ).find( string( "cmis:contentStreamLength" ) );
+-        if ( it != getProperties( ).end( ) && !it->second->getStrings( ).empty( ) )
++        if ( it != getProperties( ).end( ) && !it->second->getLongs( ).empty( ) )
+             contentLength = it->second->getLongs( ).front( );
+         return contentLength;
+     }

-- 
To view, visit https://gerrit.libreoffice.org/3921
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ef1190a4d1de7d91a67ec20330db9e1747dfdc2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Bosdonnat Cedric <cedric.bosdonnat at free.fr>



More information about the LibreOffice mailing list