[PATCH] Fix fdo#64751 – Header & footer blue tags empty

Khaled Hosny (via Code Review) gerrit at gerrit.libreoffice.org
Mon May 20 07:04:44 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/3980

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/3980/1

Fix fdo#64751 – Header & footer blue tags empty

No idea FontMetric::GetHeight() is supposed to mean, probably the code
here meant GetLineHeight(). What it actually need is GetAscent(), so use
it instead (which is the same as GetLineHeight() - GetDescent()).

Change-Id: Ic467e56ed6b8d245ac7800f94e6d40030833328b
---
M sw/source/ui/docvw/HeaderFooterWin.cxx
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/sw/source/ui/docvw/HeaderFooterWin.cxx b/sw/source/ui/docvw/HeaderFooterWin.cxx
index 970e541..eb88d53 100644
--- a/sw/source/ui/docvw/HeaderFooterWin.cxx
+++ b/sw/source/ui/docvw/HeaderFooterWin.cxx
@@ -291,7 +291,7 @@
     GetTextBoundRect( aTextRect, String( m_sLabel ) );
 
     FontMetric aFontMetric = GetFontMetric( GetFont() );
-    double nTextOffsetY = aFontMetric.GetHeight() - aFontMetric.GetDescent() + TEXT_PADDING;
+    double nTextOffsetY = aFontMetric.GetAscent() + TEXT_PADDING;
     Point aTextPos( TEXT_PADDING, nTextOffsetY );
 
     basegfx::B2DHomMatrix aTextMatrix( createScaleTranslateB2DHomMatrix(

-- 
To view, visit https://gerrit.libreoffice.org/3980
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic467e56ed6b8d245ac7800f94e6d40030833328b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Khaled Hosny <khaledhosny at eglug.org>



More information about the LibreOffice mailing list