[PATCH] String to OUString
Donizete Waterkemper (via Code Review)
gerrit at gerrit.libreoffice.org
Thu May 23 05:46:54 PDT 2013
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4012
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/4012/1
String to OUString
Committer: Donizete <dwater2 at gmail.com>
Changes to be committed:
modified: sc/qa/unit/ucalc.cxx
modified: sc/source/core/tool/cellkeytranslator.cxx
modified: sc/source/filter/excel/xiescher.cxx
modified: sc/source/filter/inc/xeescher.hxx
modified: sc/qa/unit/ucalc.cxx
modified: sc/source/core/tool/cellkeytranslator.cxx
modified: sc/source/filter/excel/xiescher.cxx
modified: sc/source/filter/inc/xeescher.hxx
modified: sc/source/filter/inc/xiescher.hxx
modified: sc/source/ui/vba/vbahelper.cxx
Your branch is ahead of 'origin/master' by 1 commit.
Change-Id: I0a6bba13d71b45a7f9161030073d4d3399ea6ad5
---
M sc/qa/unit/ucalc.cxx
M sc/source/core/tool/cellkeytranslator.cxx
M sc/source/filter/excel/xiescher.cxx
M sc/source/filter/inc/xeescher.hxx
M sc/source/filter/inc/xiescher.hxx
M sc/source/ui/vba/vbahelper.cxx
6 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 940b41e..a1df8c2 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -6584,5 +6584,3 @@
}
CPPUNIT_PLUGIN_IMPLEMENT();
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/core/tool/cellkeytranslator.cxx b/sc/source/core/tool/cellkeytranslator.cxx
index ec01049..b2ccd8f 100644
--- a/sc/source/core/tool/cellkeytranslator.cxx
+++ b/sc/source/core/tool/cellkeytranslator.cxx
@@ -44,17 +44,17 @@
static LocaleMatch lclLocaleCompare(const Locale& rLocale1, const Locale& rLocale2)
{
LocaleMatch eMatchLevel = LOCALE_MATCH_NONE;
- if ( !rLocale1.Language.compareTo(rLocale2.Language) )
+ if ( rLocale1.Language != rLocale2.Language )
eMatchLevel = LOCALE_MATCH_LANG;
else
return eMatchLevel;
- if ( !rLocale1.Country.compareTo(rLocale2.Country) )
+ if ( rLocale1.Country != rLocale2.Country )
eMatchLevel = LOCALE_MATCH_LANG_COUNTRY;
else
return eMatchLevel;
- if ( !rLocale1.Variant.compareTo(rLocale2.Variant) )
+ if ( rLocale1.Variant != rLocale2.Variant )
eMatchLevel = LOCALE_MATCH_ALL;
return eMatchLevel;
diff --git a/sc/source/filter/excel/xiescher.cxx b/sc/source/filter/excel/xiescher.cxx
index bfdd175..b8e113d 100644
--- a/sc/source/filter/excel/xiescher.cxx
+++ b/sc/source/filter/excel/xiescher.cxx
@@ -3043,7 +3043,7 @@
if( IsOcxControl() )
{
// #i26521# form controls to be ignored
- if( maClassName.EqualsAscii( "Forms.HTML:Hidden.1" ) )
+ if( maClassName.equalsAscii( "Forms.HTML:Hidden.1" ) )
{
SetProcessSdrObj( false );
return;
diff --git a/sc/source/filter/inc/xeescher.hxx b/sc/source/filter/inc/xeescher.hxx
index 205b4cb..25e0541 100644
--- a/sc/source/filter/inc/xeescher.hxx
+++ b/sc/source/filter/inc/xeescher.hxx
@@ -27,6 +27,8 @@
#include <com/sun/star/chart/XChartDocument.hpp>
#include "svx/sdtaitm.hxx"
#include <boost/shared_ptr.hpp>
+#include "rtl/ustring.h"
+#include "rtl/ustring.hxx"
class ScPostIt;
@@ -252,7 +254,7 @@
virtual void WriteSubRecs( XclExpStream& rStrm );
private:
- String maClassName; /// Class name of the control.
+ OUString maClassName; /// Class name of the control.
sal_uInt32 mnStrmStart; /// Start position in 'Ctls' stream.
sal_uInt32 mnStrmSize; /// Size in 'Ctls' stream.
};
diff --git a/sc/source/filter/inc/xiescher.hxx b/sc/source/filter/inc/xiescher.hxx
index 088c6d5..3595f41 100644
--- a/sc/source/filter/inc/xiescher.hxx
+++ b/sc/source/filter/inc/xiescher.hxx
@@ -29,6 +29,9 @@
#include "xistring.hxx"
#include <boost/shared_ptr.hpp>
#include <oox/ole/olehelper.hxx>
+#include "rtl/ustring.h"
+#include "rtl/ustring.hxx"
+
namespace com { namespace sun { namespace star {
namespace drawing { class XShape; }
namespace form { class XForm; }
@@ -905,7 +908,7 @@
private:
Graphic maGraphic; /// Picture or OLE placeholder graphic.
Rectangle maVisArea; /// Size of graphic.
- String maClassName; /// Class name of embedded OLE object.
+ OUString maClassName; /// Class name of embedded OLE object.
sal_uInt32 mnStorageId; /// Identifier of the storage for this object.
sal_Size mnCtlsStrmPos; /// Position in 'Ctls' stream for this control.
sal_Size mnCtlsStrmSize; /// Size in 'Ctls' stream for this control.
@@ -1295,5 +1298,3 @@
// ============================================================================
#endif
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/vba/vbahelper.cxx b/sc/source/ui/vba/vbahelper.cxx
index d6b5552..197b311 100644
--- a/sc/source/ui/vba/vbahelper.cxx
+++ b/sc/source/ui/vba/vbahelper.cxx
@@ -563,7 +563,7 @@
// I wonder why comparing lexicographically is done
// when its a match is whats interesting?
//if (SearchList[i].compareTo(SearchString) == 0)
- if ( SearchList[i].equals( SearchString ) )
+ if ( SearchList[i] == SearchString )
{
retvalue = i;
break;
--
To view, visit https://gerrit.libreoffice.org/4012
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a6bba13d71b45a7f9161030073d4d3399ea6ad5
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Donizete Waterkemper <dwater2 at gmail.com>
More information about the LibreOffice
mailing list