[PATCH] scripting: get CreateUnoDialog() work again

Miklos Vajna (via Code Review) gerrit at gerrit.libreoffice.org
Fri May 24 03:56:53 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/4023

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/4023/1

scripting: get CreateUnoDialog() work again

Trivial reproducer:

Dim Dlg As Object
DialogLibraries.LoadLibrary("Standard")
Dlg = CreateUnoDialog(DialogLibraries.Standard.Dialog1)
Dlg.Execute()
Dlg.dispose()

Regression from 6c61b20a8d4a6dcac28801cde82a211fb7e30654.

Change-Id: Ia62778c6d94f54e6097a307701e5c81be847665d
---
M scripting/source/dlgprov/dlgprov.cxx
1 file changed, 2 insertions(+), 1 deletion(-)



diff --git a/scripting/source/dlgprov/dlgprov.cxx b/scripting/source/dlgprov/dlgprov.cxx
index 8c645a3..2d96b9d 100644
--- a/scripting/source/dlgprov/dlgprov.cxx
+++ b/scripting/source/dlgprov/dlgprov.cxx
@@ -149,9 +149,10 @@
         // Set resource property
         if( xStringResourceManager.is() )
         {
+            Reference< beans::XPropertySet > xDlgPSet( xDialogModel, UNO_QUERY );
             Any aStringResourceManagerAny;
             aStringResourceManagerAny <<= xStringResourceManager;
-            xDialogModel->setPropertyValue( aResourceResolverPropName, aStringResourceManagerAny );
+            xDlgPSet->setPropertyValue( aResourceResolverPropName, aStringResourceManagerAny );
         }
 
         return xDialogModel;

-- 
To view, visit https://gerrit.libreoffice.org/4023
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia62778c6d94f54e6097a307701e5c81be847665d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Miklos Vajna <vmiklos at suse.cz>



More information about the LibreOffice mailing list