[PATCH libreoffice-4-0] fdo#51296 Patch modifies ctrl+click behaviour to be like wri...

Akash Shetye (via Code Review) gerrit at gerrit.libreoffice.org
Fri May 24 10:27:18 PDT 2013


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/4029

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/4029/1

fdo#51296 Patch modifies ctrl+click behaviour to be like writer.

ctrl+click on hyperlink does not open link if the ctrl+click security setting is disabled.

Change-Id: I2754b0c3d977208e28daa25502145bb29c3ef4c8
---
M sc/source/core/data/global.cxx
1 file changed, 2 insertions(+), 1 deletion(-)



diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index 74ba29b..53cba0b 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -934,9 +934,10 @@
         //Ctrl key is pressed and ctrl+click hyperlink security control is set
         bProceedHyperlink = true;
     }
-    else if( !aSecOpt.IsOptionSet( SvtSecurityOptions::E_CTRLCLICK_HYPERLINK ) )
+    else if( !(nScClickMouseModifier & KEY_MOD1) && !aSecOpt.IsOptionSet( SvtSecurityOptions::E_CTRLCLICK_HYPERLINK ) )
     {
         //ctrl+click hyperlink security control is disabled just click will do
+        //However if ctrl+click happens the condition fails
         bProceedHyperlink = true;
     }
     if ( !bProceedHyperlink )

-- 
To view, visit https://gerrit.libreoffice.org/4029
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2754b0c3d977208e28daa25502145bb29c3ef4c8
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Akash Shetye <shetyeakash at gmail.com>



More information about the LibreOffice mailing list