oox service mess
Stephan Bergmann
sbergman at redhat.com
Thu May 30 08:49:42 PDT 2013
Before
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=8ada1cd2846e5e60ad63250c68ddea3a9356546f>
"move excel related oox bits to sc," the following six UNO service
implementations were listed in oox/util/oox.component, included in
oox_component_getFactory (source/core/services.cxx), and implemented in
the oox library:
> oox::ole::WordVbaProjectFilter, "com.sun.star.comp.oox.WordVbaProjectFilter"
> oox::xls::BiffDetector, "com.sun.star.comp.oox.xls.BiffDetector"
> oox::xls::ExcelFilter, "com.sun.star.comp.oox.xls.ExcelFilter"
> oox::xls::ExcelBiffFilter, "com.sun.star.comp.oox.xls.ExcelBiffFilter"
> oox::xls::ExcelVbaProjectFilter, "com.sun.star.comp.oox.xls.ExcelVbaProjectFilter"
> oox::xls::OOXMLFormulaParser, "com.sun.star.comp.oox.xls.FormulaParser"
However, with that commit (making its debut in LO 3.6.0, it appears):
> oox::xls::ExcelFilter, "com.sun.star.comp.oox.xls.ExcelFilter"
is now correctly listed in sc/util/scfilt.component, included in
scfilt_component_getFactory (sc/source/filter/excel/xestream.cxx), and
its implementation moved to the scfilt library.
> oox::xls::OOXMLFormulaParser, "com.sun.star.comp.oox.xls.FormulaParser"
is erroneously listed in sc/util/scfilt.component but not included in
scfilt_component_getFactory (sc/source/filter/excel/xestream.cxx); its
implementation got initially moved to the scfilt library, but has since
been removed as it was unreferenced.
> oox::xls::BiffDetector, "com.sun.star.comp.oox.xls.BiffDetector"
> oox::xls::ExcelBiffFilter, "com.sun.star.comp.oox.xls.ExcelBiffFilter"
> oox::xls::ExcelVbaProjectFilter, "com.sun.star.comp.oox.xls.ExcelVbaProjectFilter"
are all suspiciously neither listed in sc/util/scfilt.component nor
included in scfilt_component_getFactory
(sc/source/filter/excel/xestream.cxx), but their implementations were
initially moved to the scfilt library and have since been removed as
they were unreferenced.
> oox::ole::WordVbaProjectFilter, "com.sun.star.comp.oox.WordVbaProjectFilter"
appears to have been removed for good, neither listed in
sc/util/scfilt.component, nor included in scfilt_component_getFactory
(sc/source/filter/excel/xestream.cxx), nor has its implementation been
moved to the scfilt library.
Can anybody shed light on which parts of this were intentional and which
were accidental damage?
Stephan
More information about the LibreOffice
mailing list