[PATCH] Remove #define A2S() in PanelFactory.cxx
Christina Roßmanith (via_Code_Review)
gerrit at gerrit.libreoffice.org
Thu May 30 13:32:24 PDT 2013
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/4108
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/4108/1
Remove #define A2S() in PanelFactory.cxx
Change-Id: I650e5826d26b3a86dcddd517ae1f917d1edaedd1
---
M sd/source/ui/sidebar/PanelFactory.cxx
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/sd/source/ui/sidebar/PanelFactory.cxx b/sd/source/ui/sidebar/PanelFactory.cxx
index 53fbe58..e58ce5d 100644
--- a/sd/source/ui/sidebar/PanelFactory.cxx
+++ b/sd/source/ui/sidebar/PanelFactory.cxx
@@ -44,8 +44,6 @@
using namespace ::sd::framework;
using ::rtl::OUString;
-#define A2S(pString) (OUString(pString))
-
namespace sd {
extern ::Window * createTableDesignPanel (::Window* pParent, ViewShellBase& rBase);
}
@@ -153,11 +151,11 @@
::Window* pParentWindow = VCLUnoHelper::GetWindow(xParentWindow);
if ( ! xParentWindow.is() || pParentWindow==NULL)
throw RuntimeException(
- A2S("PanelFactory::createUIElement called without ParentWindow"),
+ OUString("PanelFactory::createUIElement called without ParentWindow"),
NULL);
if ( ! xFrame.is())
throw RuntimeException(
- A2S("PanelFactory::createUIElement called without XFrame"),
+ OUString("PanelFactory::createUIElement called without XFrame"),
NULL);
// Tunnel through the controller to obtain a ViewShellBase.
@@ -171,7 +169,7 @@
pBase = pController->GetViewShellBase();
}
if (pBase == NULL)
- throw RuntimeException(A2S("can not get ViewShellBase for frame"), NULL);
+ throw RuntimeException(OUString("can not get ViewShellBase for frame"), NULL);
// Get bindings from given arguments.
const sal_uInt64 nBindingsValue (aArguments.getOrDefault("SfxBindings", sal_uInt64(0)));
--
To view, visit https://gerrit.libreoffice.org/4108
To unsubscribe, visit https://gerrit.libreoffice.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I650e5826d26b3a86dcddd517ae1f917d1edaedd1
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christina Roßmanith <ChrRossmanith at web.de>
More information about the LibreOffice
mailing list