dubious code in dbaccess/source/core/api/KeySet.cxx?
Stephan Bergmann
sbergman at redhat.com
Wed Oct 2 09:28:39 PDT 2013
OKeySet::deleteRows in dbaccess/source/core/api/KeySet.cxx contains the loop
> for(;pBegin != pEnd;++pBegin)
> {
> aSql.append(sCon + aOr);
> }
that appends the exact same text to aSql (pEnd-pBegin) number of times,
which---at least to an SQL-ignoramus---looks dubious. (On the other
hand, the code appears to be effectively like that since the beginning.)
Stephan
More information about the LibreOffice
mailing list