PATCH - SDRemote LO
andrzej at ahunt.org
Sun Oct 6 07:45:25 PDT 2013
Thanks for the updated patch, there were still some minor niggles though
which I had to fix (see bottom of email).
Currently your patch only changes the sound settings at the start of a
presentation, I'm not sure if we'd want to change back to the original
volume settings once the presentation is finished though?
The minor issues:
- android:defaultValue="true" was removed for two CheckBoxPreference
settings -- I assume this was unintentional (possibly an overly keen IDE
removing things automatically)?
- Some trailing spaces and mixes of tabs/spaces left over -- git
complains about both of these when applying patches:
Since you aren't doing a full build the git commit hooks aren't being
installed, meaning you aren't warned when there are issues with
spacing/tabs/formatting -- you can force installation of the hooks by
running "./g -z" in the LibreOffice tree. (However anyone with the
commit hooks in place, i.e. most LO devs, will have warnings shown which
prevent use of the commit until the issues are fixed -- which is what I
had to do to test the patch.)
(The cleaned up patch is attached.)
On Thu, 2013-10-03 at 14:10 -0300, Junior Cesar Oliveira wrote:
> Hi, we fixed the patch and send again.
> Att Junior
> 2013/10/1 Andrzej Hunt <andrzej at ahunt.org>
> Hi Junior,
> Unfortunately your patch includes a lot of unnecessary
> (space indentation replaced with tab-stops),
> specifically in SlideShowActivity.java it's impossible to see
> what has
> changed since the whole file has had all space-indentation
> replaced with
> tab-indentation (i.e. git thinks the whole file has been
> removed and
> (There are also a few cases of lines with trailing space which
> the git
> commit-hooks would usually complain about.)
> No idea which editor/IDE you use, but if you could change back
> to space
> indentation that would be hugely simplify reviewing the patch
> -- it
> should probably be enough to configure it to use spaces for
> (four spaces per tab) and then reformat the file (I'm guessing
> you might
> be using Eclipse?) which would remove most of the reformatting
> in the
> On Tue, 2013-10-01 at 14:49 -0300, Junior Cesar Oliveira
> > I declare that all of my past & future contributions to
> > may be licensed under
> > the MPL/LGPLv3+ dual license.
> > Hello, the patch is attached to the resolution of bug 61570
> > project. The patch has been created for the following
> > UTFPR-Brazil: Junior Cesar de Oliveira, Ana Claudia Maciel,
> > Schultz Dworak.
> > Junior.
> > _______________________________________________
> > LibreOffice mailing list
> > LibreOffice at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/libreoffice
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 5253 bytes
Desc: not available
More information about the LibreOffice