[Bug 54938] Adapt supportsService implementations to cppu::supportsService

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Oct 24 19:09:43 CEST 2013


--- Comment #12 from Marcos Souza <marcos.souza.org at gmail.com> ---
I saw a lot of places like this:

sal_Bool SAL_CALL ScTabViewObj::supportsService( const OUString& rServiceName )
    return rServiceName.equalsAscii( SCTABVIEWOBJ_SERVICE ) || 
           rServiceName.equalsAscii( SCVIEWSETTINGS_SERVICE );

So, can we just exchange this to cppu::supportsService? Or we need to some
another pieces of code?

OBS: I believe all places that test the supportsService like this have this
same function:
uno::Sequence<OUString> SAL_CALL ScTabViewObj::getSupportedServiceNames()
    uno::Sequence<OUString> aRet(2);
    OUString* pArray = aRet.getArray();
    pArray[0] = OUString( SCTABVIEWOBJ_SERVICE );
    pArray[1] = OUString( SCVIEWSETTINGS_SERVICE );
    return aRet;

with the same service name added into uno::Sequence.

With this change we can have a more standard code, at least talking about the
way we get uno service names :)

You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20131024/7bdd1181/attachment.html>

More information about the LibreOffice mailing list