Bugous bug fix

Zolnai Tamás zolnaitamas2000 at gmail.com
Thu Sep 12 01:49:26 PDT 2013

Hi Tomofumi and Cedric,

I found that the next commit is bugous:
I have problem mostly with using the ApplyLineDashing method with scale
parameter (borderlineprimitive2d.cxx).
I know two reasons why this is wrong:
- The value of aScale.getLength() increase when text zoom is decrease,
while it should decrease too. So when the text (or content of the border)
is the smallest the dashed border's snippets are the biggest, which is a
bit weird.
- The whole borderline primitive is transformed before drawing, so no need
to change the size of snippets separately, because this happens during the
mentioned transformation. Additionally this change causes the borderline
changing all the time while zooming and not just the size, but the snippets
are also moving, which is a bit disturbing.

There is a small part of the patch, which make to draw hairline primitive,
when the line is solid (before only the width was checked). Maybe this part
fixed the original bug, because as I see the hairline primitive means a
solid line.

Best regards,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130912/e95e829f/attachment.html>

More information about the LibreOffice mailing list