Cppcheck reports 'else if' condition matches previous condition (svx)

julien2412 serval2412 at yahoo.fr
Sat Apr 5 15:51:38 PDT 2014


Hello,

Cppcheck reported this
svx/source/unodraw/unomod.cxx
492	multiCondition	style	Expression is always false because 'else if'
condition matches previous condition at line 460.

Remark: It's a new kind of cppcheck detection and there are quite a lot of
false positives (at least for LO) for the moment.

Here's the code:
    460         else if( aTypeName.startsWith( "TableShape" ) )
    461         {
    462             nType = OBJ_OLE2;
    463         }
...
    492         else if( aTypeName.startsWith( "TableShape" ) )
    493         {
    494             nType = OBJ_TABLE;
    495         }

see
http://opengrok.libreoffice.org/xref/core/svx/source/unodraw/unomod.cxx#460

Which one of this block is ok?

Julien



--
View this message in context: http://nabble.documentfoundation.org/Cppcheck-reports-else-if-condition-matches-previous-condition-svx-tp4104268.html
Sent from the Dev mailing list archive at Nabble.com.


More information about the LibreOffice mailing list