[Libreoffice-commits] core.git: fdo#77123: Add option ignore kashida to the search
sbergman at redhat.com
Fri Apr 11 00:56:24 PDT 2014
On 04/08/2014 12:16 PM, Stephan Bergmann wrote:
> On 04/08/2014 09:59 AM, Faisal M. Al-Otaibi wrote:
>> commit d2771b63b94a8aae3c25c83e9dae9f83242f46c1
>> Author: Faisal M. Al-Otaibi <fmalotaibi at kacst.edu.sa>
>> Date: Tue Apr 8 09:42:20 2014 +0300
>> fdo#77123: Add option ignore kashida to the search
>> This patch will add new checkbox to ignore kashida in the
>> search and replace dialog.
>> Change-Id: I9e7179242751103b8418d922ade5b9145170ad15
>> diff --git a/offapi/com/sun/star/i18n/TransliterationModulesExtra.idl
>> index 45f7ccb..d1f675f 100644
>> --- a/offapi/com/sun/star/i18n/TransliterationModulesExtra.idl
>> +++ b/offapi/com/sun/star/i18n/TransliterationModulesExtra.idl
>> @@ -52,6 +52,8 @@ constants TransliterationModulesExtra
>> /// because we cannot extend TransliterationModule we used
>> TranslationModuleExtra and it will act the same way
>> const long ignoreDiacritics_CTL = 0x40000000;
>> + const long ignoreKashida_CTL = 0x00000800;
>> const long END_OF_MODULE = 0;
> There is a restriction on UNOIDL entity names that a name must not
> contain both underscores and lower case letters at the same time (see
> <http://www.openoffice.org/udk/common/man/typesystem.html> for details).
> We unfortunately cannot enforce that at build time due to many legacy
> violations that cannot be fixed for compatibility reasons.
> But please fix this newly introduced name to follow the rules, best by
> making it use all uppercase and underscores, like IGNORE_KASHIDA_CTL.
> The similar case of ignoreDiacritics_CTL introduced with
> "Fix fdo#52204 add new feature ignore diacritics in search for CTL"
> unfortunately slipped through into LO 4.2. But if chances are low that
> it is used by third party code, it would still be possible to change
> that now, esp. given com.sun.star.i18n.TransliterationModulesExtra is
> not published.
I changed both those identifiers now in
"Use valid UNOIDL identifiers in TransliterationModulesExtra," before
"unoidl-check: Also check for invalid UNOIDL identifiers" in place to
prevent this from happening in the future.
More information about the LibreOffice