Cppcheck reports 'else if' condition matches previous condition (svx)

Caolán McNamara caolanm at redhat.com
Fri Apr 11 04:20:49 PDT 2014

On Tue, 2014-04-08 at 20:58 +0200, Julien Nabet wrote:
> I've just pushed the fix on master. "make check" on top level was ok.
> Searching in git history during "make check", I found this commit from 2008:
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d20a47c3d50d0a88543b2355ec7340fc7455984
> which references "OBJ_TABLE"
> whereas OBJ_OLE2 was in 2001 (see 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=e24bc241b69da6789351d9bf82eab5119f09c16c) 
> I submitted a gerrit review 4.2:
> https://gerrit.libreoffice.org/8897

I'm rather reluctant to change this in 4.2 without a specific known
problem that it fixes.


More information about the LibreOffice mailing list