OutputDevice code reorganization

Kohei Yoshida kohei.yoshida at collabora.com
Tue Apr 15 08:10:58 PDT 2014


On Tue, 2014-04-15 at 10:00 -0500, Norbert Thiebaud wrote:
> On Tue, Apr 15, 2014 at 6:25 AM, Chris Sherlock
> <chris.sherlock79 at gmail.com> wrote:
> > I have moved outdev.cxx to outdev6.cxx to the directly vcl/source/outdev,
> > and into the following files:
> >
> [...]
> >
> > I think this largely helps split up the file in a more sensible layout.
> 
> I'm sure ther is plenty of room to bikesheed this to death.. but
> 1/ yeah, the output<x>.cxx thing is really not helpful
> 2/ the names superficially sound decent
> 3/ your're doing the work, and have been working and thinking about
> this class for some times now...

My only request is that the move be done in such a way that git knows
the files have been moved (in a single commit), rather than the old
files removed and new one added.

Kohei



More information about the LibreOffice mailing list