cppcheck: duplicate branch for ParaPropertyPanel (svx) + interpr7.cxx (sc)

Caolán McNamara caolanm at redhat.com
Wed Apr 16 08:30:50 PDT 2014


On Fri, 2013-09-27 at 14:52 -0700, julien2412 wrote:
> Hello,
> 
> Cppcheck reported this:
> sc/source/core/tool/interpr7.cxx
>      94                         else if(pNodeSet->nodeTab[0]->type ==
> XML_ELEMENT_NODE)
>      95                         {
>      96                             xmlNodePtr cur = pNodeSet->nodeTab[0];
>      97                             boost::shared_ptr<xmlChar>
> pChar2(xmlNodeGetContent(cur), xmlFree);
>      98                             aResult =
> OUString::createFromAscii((char*)pChar2.get());
>      99                         }
>     100                         else
>     101                         {
>     102                             xmlNodePtr cur = pNodeSet->nodeTab[0];
>     103                             boost::shared_ptr<xmlChar>
> pChar2(xmlNodeGetContent(cur), xmlFree);
>     104                             aResult =
> OUString::createFromAscii((char*)pChar2.get());
>     105                         }
> 
> See
> http://opengrok.libreoffice.org/xref/core/sc/source/core/tool/interpr7.cxx#87

So I decided to just remove the duplication for now. Markus might want
to have a look at it as the original author.

C.

(and the other issue in svx is fixed now as well as per the earlier
mail).



More information about the LibreOffice mailing list