Dead code in escherex.cxx (filter module)

[julien2412]

Hello,

Taking a look to this part:
   4442                 if ( nErrCode == ERRCODE_NONE )
   4443                 {
   4444                     p_EscherBlibEntry->meBlibType = ( eGraphicType
== GRAPHIC_BITMAP ) ? PNG : EMF;
   4445                     aStream.Seek( STREAM_SEEK_TO_END );
   4446                     p_EscherBlibEntry->mnSize = aStream.Tell();
   4447                     pGraphicAry = (sal_uInt8*)aStream.GetData();
   4448 
   4449                     if ( p_EscherBlibEntry->meBlibType == WMF )    
// the fileheader is not used
   4450                     {
   4451                         p_EscherBlibEntry->mnSize -= 22;
   4452                         pGraphicAry += 22;
   4453                     }
   4454                 }

I wonder if in line 4449 'WMF' should be changed to 'EMF' or the contrary on
line 4444.
See
http://opengrok.libreoffice.org/xref/core/filter/source/msfilter/escherex.cxx#4444
A research in Opengrok didn't help:
http://opengrok.libreoffice.org/search?q=%22eGraphicType+%3D%3D+GRAPHIC_BITMAP%22&project=core&defs=&refs=&path=&hist=

Any idea?

Julien 



--
View this message in context: http://nabble.documentfoundation.org/Dead-code-in-escherex-cxx-filter-module-tp4106079.html
Sent from the Dev mailing list archive at Nabble.com.