[SOLVED] Re: Dead code in escherex.cxx (filter module)

Julien Nabet serval2412 at yahoo.fr
Wed Apr 23 01:11:19 PDT 2014


On 23/04/2014 10:02, Miklos Vajna wrote:
> ...
>> // the fileheader is not used
>>     4450                     {
>>     4451                         p_EscherBlibEntry->mnSize -= 22;
>>     4452                         pGraphicAry += 22;
>>     4453                     }
>>     4454                 }
> However, if you change WMF to EMF here, then one wonders if you want to skip an
> EMF header as well, and the answer is probably: not (and even if you want to do
> that, the EMF header is not fixed size, so a constant 22 won't help there). So
> I would just delete the dead code here.
Thank you Miklos for your feedback, I pushed the change on master 
sources (see 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b39ee2bc8f6df28f020ed13ddc7b39d208dfc7a5)

Julien



More information about the LibreOffice mailing list