[Libreoffice-commits] core.git: canvas/source dbaccess/source oox/source reportdesign/source slideshow/source

[Joerg Sonnenberger]

On Fri, Aug 29, 2014 at 11:58:48AM +0200, Thorsten Behrens wrote:
> Jörg Sonnenberger wrote:
> > +        SurfaceSharedPtr surface(mpOwningSpriteCanvas->getBufferSurface());
> >          ::std::for_each( aUncoveredAreas.begin(),
> >                           aUncoveredAreas.end(),
> >                           ::boost::bind( &repaintBackground,
> >                                          boost::cref(pCompositingCairo),
> > -                                        boost::cref(mpOwningSpriteCanvas->getBufferSurface()),
> > +                                        boost::cref(surface),
> >                                          _1 ) );
> >
> If you need a local variable anyway - why not insted getting rid of
> the boost::cref and pass the parameter by value in the first place?
> 
> e.g. , mpOwningSpriteCanvas->getBufferSurface(), _1 ... ?

Haven't tried, was looking for the minimal change to the existing
structure. One thing to keep in mind is that getBufferSurface() creates
a temporary variable. It doesn't return a reference itself.

Joerg