Bug introduced during translation? (was: [Bug 39674] find / fix all German spellings in internal APIs)

[Nino Novak]

Hi,

by chance I looked into this commit and seeing the lines cited below, I'm
asking myself how many strange bugs or regressions are introduced this way.

Here, the names of two variables were translated - which would be ok, but
only if all of their occurences were changed accordingly.

In this case, the translation of only one occurence in my eyes (though I'm
not a dev) *must* break something.

Thomas, did you notice this?

Nino

partly citing
<http://cgit.freedesktop.org/libreoffice/core/tree/sc/source/core/tool/interpr2.cxx?id=675073a7766007ae0d289dcd634d5153bbd891c3>:
-------------------------------------
diff --git a/sc/source/core/tool/interpr2.cxx b/sc/source/core/tool/interpr2.cxx
index ac6d71e..1971e56 100644
--- a/sc/source/core/tool/interpr2.cxx
+++ b/sc/source/core/tool/interpr2.cxx
[...]
@@ -1399,9 +1397,9 @@ void ScInterpreter::ScVDB()
else
{
- double fDauer1=fDauer;
+ double fTimeLength1=fTimeLength;
-------------------------------------

On 30.08.2014 10:48, bugzilla-daemon at freedesktop.org wrote:
> Commit Notification <mailto:libreoffice-commits at lists.freedesktop.org>
> changed bug 39674 <https://bugs.freedesktop.org/show_bug.cgi?id=39674>
> What 	Removed 	Added
> Whiteboard 	EasyHack DifficultyBeginner SkillScript target:4.1.0
> target:4.2.0 	EasyHack DifficultyBeginner SkillScript target:4.1.0
> target:4.2.0 target:4.4.0
> 
> *Comment # 16 <https://bugs.freedesktop.org/show_bug.cgi?id=39674#c16> on
> bug 39674 <https://bugs.freedesktop.org/show_bug.cgi?id=39674> from Commit
> Notification <mailto:libreoffice-commits at lists.freedesktop.org> *
> 
> Jennifer Liebel committed a patch related to this issue.
> It has been pushed to "master":
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=5605a36a31081875087ff5cb28b84790845ba695
> 
> fdo#39674: Improved translation
> 
> 
> 
> The patch should be included in the daily builds available at
> http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
> information about daily builds can be found at:
> http://wiki.documentfoundation.org/Testing_Daily_Builds
> Affected users are encouraged to test the fix and report feedback.
> 
> ----------------------------------------------------------------------------
> You are receiving this mail because:
> 
>   * You are on the CC list for the bug.
> 
> 
>