[Bug 54938] Adapt supportsService implementations to cppu::supportsService

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Feb 3 16:04:40 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=54938

--- Comment #41 from Alexandre Vicenzi <vicenzi.alexandre at gmail.com> ---
(In reply to comment #35)
> (In reply to comment #34)
> > sal_Bool SAL_CALL FilterBase::supportsService( const OUString& rServiceName
> > ) throw( RuntimeException )
> > {
> >    return
> >    (rServiceName == "com.sun.star.document.ImportFilter" ) ||
> >    (rServiceName == "com.sun.star.document.ExportFilter" );
> > }
> 
> Please always give a pointer to the relevant file, apparently
> oox/source/core/filterbase.cxx in this case.
> 
> As currrent FilterBase::supportsService behavior is in line with
> FilterBase::getSupportedServiceNames behavior (defined just afterwards), the
> usual approach of forwarding to cppu::supportsService just works here.  Or
> what am I missing?

It's OK. I forgot to check getSupportedServiceNames.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20140204/78ef92df/attachment.html>


More information about the LibreOffice mailing list