[SOLVED] Re: Cppcheck Same expression on both sides of '|' in PresenterPaneBorderManager.cxx (sdext)

Julien Nabet serval2412 at yahoo.fr
Sat Feb 8 09:11:54 CET 2014


On 07/02/2014 12:57, Caolán McNamara wrote:
> On Fri, 2014-01-31 at 06:49 -0800, julien2412 wrote:
>> Hello,
>>
>> Cppcheck reported this:
>> sdext/source/presenter/PresenterPaneBorderManager.cxx
>> 171	duplicateExpression	style	Same expression on both sides of '|'
>> I thought about putting this:
>>          case mnOutside:
>>          case mnOutside | mnLeft:
>>
>> Is it ok or do I miss something?
> I think you should go ahead with that. Seems the sane thing to do.
Patch pushed on master (see 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=4415f6b7b19c1e6f805c6a7c190c2bebeebdd648)
Thank you Caolán!

Julien


More information about the LibreOffice mailing list