Fwd: Re: [Libreoffice-commits] core.git: Move string hash function into String class.

[Muthu Subramanian]

On 02/14/2014 09:39 PM, Stephan Bergmann wrote:
>
> Sure, but how exactly rtl::O[U]String::hashCode should behave is 
> somewhat orthogonal to the point that the current design of 
> SdPage::getHash is needlessly resource-hungry.  And, as I wrote, "I 
> wouldn't mind changing the rtl string classes' hashCode behavior."
>
Then I guess I didn't understand your view point completely :(
I do agree that SdPage::getHash is resource hungry - currently.
It would hopefully reduce its resource hungriness as we progress. Then 
again, it also depends on which resource ;)

>
> SfxItemSet::getHash and SfxItemSet::stringify
Na...these are used... And that is the reason why I moved the hashCode 
out to O[U]String

>
>
> That's my point---none of the getHash/stringify functions in SdPage, 
> SdrObject, nor SfxItemSet should be virtual.
If its allowed to be inherited, its good to be virtual? Especially if we 
are looking at hash folding?

I'll do what best I understood from this conversation (I hope I 
understood right!) and leave the rest to you? Hope that's fine, please?

Thanks!
Muthu Subramanian
>
> Stephan