Fwd: Re: [Libreoffice-commits] core.git: Move string hash function into String class.

[Muthu Subramanian]

On 02/18/2014 05:53 PM, Stephan Bergmann wrote:
>
> While a well-designed interface between a base class and its 
> derivations (of which virtual functions are a part) is desirable, a 
> virtual function carries a relatively high maintenance cost.  So 
> please never declare functions as virtual until they actually need to be.
ah...makes sense.
>
> Just pushed 
> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=042725a5dadc9f2c6368ca451b6d20046129b8af> 
> "Stick to a single O[U]String hash function" based on what we 
> discussed here.  Hope it still matches the requirements of 
> SfxItemSet::getHash and SdPage::getHash (where I must confess that I 
> don't understand what those requirements are) as well as the 
> requirements of the svl::SharedStringPool clients (see the commit 
> message for details).
Thank you!
It seems fine from what I checked - I will do check it in detail 
sometime this week - I don't see any problems though.

Thank you so much!
Muthu Subramanian

>
> Stephan