[Libreoffice-commits] core.git: fwk: Use constructor feature for ModuleUIConfigurationManager
Matúš Kukan
matus.kukan at collabora.com
Wed Jan 22 00:47:39 PST 2014
On Tue, 2014-01-21 at 16:28 +0100, Stephan Bergmann wrote:
> Removing XInitialization from a service implementation is always a
> delicate move regarding compatibility. Even though the new-style
> service css.ui.ModuleUIConfigurationManager does not mention
> XInitialization, the old-style variant (prior to
> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=9c41a60c0d802c618ac414822615a5c9e9e92f9f>
> "fdo#46808, Convert ui::ModuleUIConfigurationManager service to new
> style") did, and there is always a chance that (external) code obtains
> the service implementation via a non-argument queryInstance call and
> then explicitly queries for XInitialization.
>
> So although this change is most probably justified, it is nevertheless
> incompatible. Matúš, can you please manually list your relevant past
> changes at
> <https://wiki.documentfoundation.org/ReleaseNotes/4.3#API_changes> and
> add "[API CHANGE]" to the commit messages of relevant future changes (to
> allow for semi-automatic tracking)?
Makes sense,
I've found 8, and added them to the wiki.
Thanks,
Matus
More information about the LibreOffice
mailing list