Changes in SvgSvgNode::getSvgStyleAttributes()

Regina Henschel rb.henschel at t-online.de
Tue Jul 15 01:50:34 PDT 2014


Hi Tomaž,

forget my previous mail. The error is indeed that the old version of 
SvgSvgNode::getSvgStyleAttributes() does not consider the styles from 
the style element.

Kind regards
Regina

Tomaž Vajngerl schrieb:
> Hi,
>
> On Mon, Jul 14, 2014 at 8:15 PM, Regina Henschel
> <rb.henschel at t-online.de> wrote:
>> Hi all,
>>
>> I see some changes in fdo#78554 which I do not understand. In AOO the method
>> SvgSvgNode::getSvgStyleAttributes() is a simple getter for the member
>> maSvgStyleAttributes.
>>
>> First was a change in commit 1d89cd08ab3566375e30b17f1b17bc240ca907a4. But
>> the commit message does not mention, what problem this change solves. I see
>> no bug report and no test document.
>
> [1] is the test document - it doesn't work correctly in AOO 4.1
> I have "reverse engeneered" what fdo#78554 wants to fix and started
> writing a test, but it is not really finished yet.
>
>> The following changes try to solve a problem which seems to be introduced
>> with the above mentioned commit.
>>
>> I ask, because AOO has no problems with the file attached to fdo#78554. The
>> text is there when opening via File > Open and same when insert via Insert >
>> Picture.
>>
>> Kind regards
>> Regina
>
> [1] http://cgit.freedesktop.org/libreoffice/core/tree/svgio/qa/cppunit/data/RectWithParentStyles.svg
>



More information about the LibreOffice mailing list