SAL_NO_VTABLE in formula

Markus Mohrhard markus.mohrhard at googlemail.com
Thu May 22 18:14:30 PDT 2014


Hey,

so by going through Lsan reports I noted that we have a few classes in
formula that are marked with SAL_NO_VTABLE and therefore have no virtual
protected destructors, This prevents us from deleting some of these
instances and it looks like people just leaked them in the past.

Is there any reason not to remove the SAL_NO_VTABLE and make the destructor
virtual and public. I"m talking especially about
include/formula/IFunctionDescription.hxx where the use of SAL_NO_VTABLE
looks like premature optimization to me.

Regards,
Markus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20140523/dd843516/attachment.html>


More information about the LibreOffice mailing list