LibreOffice, about avoiding "attempt to erase from container with a past-the-end iterator"

[julien2412]

Hello,

I noticed this interesting change
http://cgit.freedesktop.org/libreoffice/core/commit/?id=72827968e606adcdf8c16e5381b887180975ae46
("Try to avoid "attempt to erase from container with a past-the-end
iterator")
I tried to search similar cases in Opengrok and found some of them (because
quite often a same mistake is made several times)

See
http://opengrok.libreoffice.org/search?q=%22erase%28+std%3A%3Afind%22&project=core&defs=&refs=&path=&hist=

Should we apply the fix for all of them or it's not so automatic because in
some cases we're 100% sure "find" function retrieves a dereferenceable
iterator?

Remark : some would say, no bug no change, I'd tend to think to prevent from
waiting for the bugs if we can be sure of the fix.

Julien



--
View this message in context: http://nabble.documentfoundation.org/LibreOffice-about-avoiding-attempt-to-erase-from-container-with-a-past-the-end-iterator-tp4110615.html
Sent from the Dev mailing list archive at Nabble.com.