SfxFilterMatcher::GuessFilter called with sal_False instead of SfxFilterGlags

Matteo Casalin matteo.casalin at yahoo.com
Mon Nov 17 03:31:55 PST 2014


Great! Thanks Caolán.
Matteo

On Mon, 17 Nov 2014 10:42:03 +0000
Caolán McNamara <caolanm at redhat.com> wrote:

> On Sun, 2014-11-16 at 19:59 +0100, Matteo Casalin wrote:
> > Hi all,
> >      I found some call sites [1] for SfxFilterMatcher::GuessFilter which 
> > pass a sal_False value instead of a SfxFilterFlags, and among the 
> > defined flags I just see SFX_FILTER_VERSION_NONE (which is never used in 
> > the code, anyway) with a 0 value. These calls seems to be like this from 
> > the beginning and I really haven't got a clue if sal_False should be 
> > changed to 0 (or SFX_FILTER_VERSION_NONE), to something else, just 
> > deleted, or whatever.
> 
> The safest and easiest thing IMO is to just change from from sal_False
> to SFX_FILTER_VERSION_NONE so I've done that change now.
> 
> C.
> 
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


More information about the LibreOffice mailing list