Fwd: Re: [Libreoffice-commits] core.git: Revert "Revert "Make VCartesianAxis::get2DAxisMainLine() truly const method.""

Markus Mohrhard markus.mohrhard at googlemail.com
Tue Oct 14 08:08:47 PDT 2014

Only sent that to Stephan.
---------- Forwarded message ----------
From: "Markus Mohrhard" <markus.mohrhard at googlemail.com>
Date: Oct 14, 2014 10:08 PM
Subject: Re: [Libreoffice-commits] core.git: Revert "Revert "Make
VCartesianAxis::get2DAxisMainLine() truly const method.""
To: "Stephan Bergmann" <sbergman at redhat.com>

On Oct 14, 2014 9:15 PM, "Stephan Bergmann" <sbergman at redhat.com> wrote:
> Markus,
> Can you please clarify the intended audience of --enable-chart-tests, and
augment its description in configure.ac in case it is not intended for
general usage.
> I had apparently at some point added it to my autogen.input in good
faith, but can no longer reconstruct where I drew that faith from.

So it is a bit complicated. In contrast to draw/impress the xshape test in
chart2 are not perfectly stable across machines. There are many factors
that may result in differences between different computers.

The reference machine for these tests was the @50 tinderbox which always
produced the same results as my local Linux machine (which of course was
helpful for me). Personally I regard all test failures of these tests a bit
sceptical. I always check if there was a chart2 change that explains the
test failure and if so regenerate the reference files (of course checking
it is not a regression is still necessary). If there is none it is for sure
a regression and the idea was that it is easier to find some of the
problems introduced by commits to drawinglayer already through the
automated tests.

So in a perfect world these tests would be stable and everyone could run
them, in reality it is best to run the only on a few machines that are
known to work and maintained by people who can judge if a test failure is a
regression or not.

Does that help?
> Stephan
> On 10/14/2014 03:09 PM, Stephan Bergmann wrote:
>> commit 658f031bb155474fa64e69fb76326b29ef4a642c
>> Author: Stephan Bergmann <sbergman at redhat.com>
>> Date:   Tue Oct 14 15:07:31 2014 +0200
>>      Revert "Revert "Make VCartesianAxis::get2DAxisMainLine() truly
const method.""
>>      This reverts commit bf302000ea8849ac7ecd9162f3014bac9da4406e,
>>      as clarified on IRC, --enable-chart-tests is known flaky and not
intended to be
>>      used by anybody but moggi.
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20141014/9c08f18d/attachment.html>

More information about the LibreOffice mailing list