FontCharMap change - request for comment
chris.sherlock79 at gmail.com
Wed Sep 24 01:55:53 PDT 2014
As many of you know, I'm particularly interested in VCL and how it fits
together. One thing I've noticed is that a lot of VCL classes have their
own built-in reference counting code.
I am interested in changing this situation. In
https://gerrit.libreoffice.org/#/c/11565/4 I used a shared_ptr, but I have
since switched to use boost's intrusive_ptr
I am interested in someone looking at my general approach. In a nutshell, I
have kept a reference counter variable in FontCharMap, and merged
ImplFontCharMap with FontCharMap. I have also used a typedef
PtrFontCharMap, which is intrusive_ptr<FontCharMap>.
I would love to see some comments, good or bad so that I can start rolling
out this sort of thing to other parts of the VCL module.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the LibreOffice