About tdf#90566: Theme::disposing(void) memory leak: maChangeListeners is not properly disposed

[julien2412]

Hello,

I read about tdf#90566, Theme::disposing(void) memory leak:
maChangeListeners is not properly disposed and wondered why we couldn't just 
remove the 2 first lines of the disposing function (see
http://opengrok.libreoffice.org/xref/core/sfx2/source/sidebar/Theme.cxx#390)
+ replace "aListeners" by "maChangeListeners"?
I mean why adding an intermediate variable instead of just using the initial
variable?

I found this type of construct at different locations in sfx2, see
http://opengrok.libreoffice.org/search?q=swap&project=core&defs=&refs=&path=sfx2%2Fsource%2Fsidebar&hist=

Julien



--
View this message in context: http://nabble.documentfoundation.org/About-tdf-90566-Theme-disposing-void-memory-leak-maChangeListeners-is-not-properly-disposed-tp4146014.html
Sent from the Dev mailing list archive at Nabble.com.