New Defects reported by Coverity Scan for LibreOffice

[Caolán McNamara]

On Wed, 2015-04-15 at 17:24 -0700, scan-admin at coverity.com wrote:

> *** CID 1294407:  Incorrect expression  (COPY_PASTE_ERROR)
> /sc/source/core/tool/compiler.cxx: 5037 in ScCompiler::HandleTableRef()()
> 5031                                 aColRange = mpToken->GetDoubleRef()->toAbs( aPos);
> 5032                             }
> 5033                             break;
> 5034                         default:
> 5035                             ;   // nothing
> 5036                     }
> >>>     CID 1294407:  Incorrect expression  (COPY_PASTE_ERROR)
> >>>     "aStart" in "aColRange.aEnd.Row() != aDBRange.aStart.Row()" looks like a copy-paste error.
> 5037                     if (aColRange.aStart.Row() != aDBRange.aStart.Row() || aColRange.aEnd.Row() != aDBRange.aStart.Row())
> 5038                         aRange = ScRange( ScAddress::INITIALIZE_INVALID);
> 5039                     else
> 5040                     {
> 5041                         aColRange.aEnd.SetRow( aRange.aEnd.Row());
> 5042                         aRange = aRange.Intersection( aColRange);

caolanm->erack: should it be

... || aColRange.aEnd.Row() != aDBRange.aEnd.Row()

?

C.