FastAttributeList and docx export problems

Matúš Kukan matus.kukan at gmail.com
Fri Apr 17 11:52:01 PDT 2015


Hi,

Before 9ae701509add0f0192b02fab787c6acbc64be349 FastAttributeList used
map to store attribute="value" pairs in XML elements. I guess I did
not realize when changing map to list that it will cause problems
because somebody writes the same attribute twice.

One problem is described in
https://bugs.documentfoundation.org/show_bug.cgi?id=85769 for which I
did https://gerrit.libreoffice.org/#/c/15367/
but no idea if that fix is OK.
Caolan tried to avoid assert with 969c1d5e44ed11e08f64334ed65ce01d2fa54acb
(but I now get "Assertion `aColorString.equalsL(pExistingValue,
rtl_str_getLength(pExistingValue))' failed." for docx/fdo72640-3.docx)

The question is: should we return to using map in Writer or try to fix
these problems one by one as they come?

Feel free to approve https://gerrit.libreoffice.org/#/c/15367/ :-)

Thanks,

Matus


More information about the LibreOffice mailing list