[Libreoffice-commits] you are wrong you stupid compiler, it would crash or not used unitialized

Stephan Bergmann sbergman at redhat.com
Mon Apr 27 00:14:31 PDT 2015


On 04/25/2015 02:25 AM, Markus Mohrhard wrote:
> commit c39890d07dc857157756f0b6e57a2c8cbb3b4f54
> Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
> Date:   Sat Apr 25 02:23:46 2015 +0200
>
>      you are wrong you stupid compiler,it would crash or not used unitialized
>
>      Change-Id: I7ca4399d7e6c83a480d5e508ac6ac711fe71644d
>
> diff --git a/oox/source/export/chartexport.cxx b/oox/source/export/chartexport.cxx
> index 80bcfba..72ed205 100644
> --- a/oox/source/export/chartexport.cxx
> +++ b/oox/source/export/chartexport.cxx
> @@ -1058,7 +1058,7 @@ void ChartExport::exportTitle( Reference< XShape > xShape )
>       if( bVertical )
>           sWritingMode = "wordArtVert";
>
> -    sal_Int32 nRotation;
> +    sal_Int32 nRotation = 0;
>       xPropSet->getPropertyValue("TextRotation") >>= nRotation;
>
>       pFS->singleElement( FSNS( XML_a, XML_bodyPr ),

note that when bool operator >>=(Any const &, T & value) returns false, 
value is left unchanged


More information about the LibreOffice mailing list