[Libreoffice-commits] core.git: tdf#87702: Addition of Shadow sidebar tab

[Caolán McNamara]

On Tue, 2015-08-04 at 18:15 +0200, Stephan Bergmann wrote:
> > --- a/cui/source/tabpages/tpshadow.cxx
> > +++ b/cui/source/tabpages/tpshadow.cxx
> > @@ -41,7 +41,10 @@ const sal_uInt16 
> > SvxShadowTabPage::pShadowRanges[] =
> >       SDRATTR_SHADOWCOLOR,
> >       SDRATTR_SHADOWTRANSPARENCE,
> >       SID_ATTR_FILL_SHADOW,
> > -    SID_ATTR_FILL_SHADOW,
> > +    SID_ATTR_SHADOW_COLOR,
> > +    SID_ATTR_SHADOW_TRANSPARENCE,
> > +    SID_ATTR_SHADOW_XDISTANCE,
> > +    SID_ATTR_SHADOW_YDISTANCE,
> 
> Doesn't this look odd, given pShadowRanges presumably shall consist 
> of begin/end pairs?

Changed this to http://cgit.freedesktop.org/libreoffice/core/commit/?id
=94fb1a389c3be0fd5570421baa596aeb79dc5528
which should fit better

C.