Re: ‘OUTPUT_DRAWMODE_CONTRAST’ defined but not used

[Stephan Bergmann]

On 08/25/2015 05:59 PM, Khaled Hosny wrote:
> On Tue, Aug 25, 2015 at 05:54:32PM +0200, Stephan Bergmann wrote:
>> On 08/25/2015 05:30 PM, Khaled Hosny wrote:
>>> In may build I see this warning a lot:
>>> In file included from cui/source/tabpages/textattr.cxx:37:0:
>>> include/svx/dlgutil.hxx:37:28: warning: ‘OUTPUT_DRAWMODE_CONTRAST’ defined but not used [-Wunused-variable]
>>>   static const DrawModeFlags OUTPUT_DRAWMODE_CONTRAST = DrawModeFlags::SettingsLine | DrawModeFlags::SettingsFill | DrawModeFlags::SettingsText | DrawModeFlags::SettingsGradient;
>>>
>>> I’m guessing it is caused by the static in the declaration since
>>> OUTPUT_DRAWMODE_CONTRAST seems to be used somewhere.
>>
>> Compilers are free to not emit storage for that per-copilation-unit const
>> variable (what an oxymoron), and most compilers are apparently smart enough
>> to not emit a -Wunused-variable in such a case (or else the build should
>> break for many developers, assuming developers routinely configure
>> --enable-werror).  Yours just isn't
>
> I wouldn’t be able to finish any build if I turned this on, I get even
> more warnings about deprecated std::auto_ptr which seems to be used in
> boost’s get_pointer.hpp.

These would go away (or at least not cause an error) if you use 
--without-system-boost, IIUC.

>> ---some dated GCC?
>
> That is GCC 5.2.0, so I guess a rather too new one.

Odd, neither the Fedora 22 GCC 5.1.1 nor a recent trunk build (towards 
GCC 6) triggers that warning for me when building cui.